kuhyx/testsAndMisc
1
0
Fork 0
mirror of https://github.com/kuhyx/testsAndMisc.git synced 2026-07-04 20:03:12 +02:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
544 Commits 4 Branches 1 Tag 44 MiB
cffd445b0b
Commit Graph

70 Commits

Author SHA1 Message Date
Krzysztof kuhy Rudnicki
1f20f727d0 refactor(randomize_numbers): use list comprehension to achieve 100% coverage 
Replaced for loop with implicit continue with a list comprehension
using walrus operator. This avoids the coverage.py limitation with
partial branch detection on for loop continue statements.

Coverage: 99% -> 100%
 2025-12-01 20:19:02 +01:00
Krzysztof kuhy Rudnicki
57233aa8d5 refactor(keyboard_coop): remove dead/unreachable code 
- Remove unreachable force-submit check (line 351): available_letters
  always contains the clicked letter after add(letter)
- Remove unreachable hover color branch (lines 398-404): the available
  check at line 396 catches all available letters first
- Remove unused KEY_HOVER_COLOR constant
- Remove unused mouse_pos variable in _draw_keyboard
- Update test from hover to unavailable key color test

Coverage: 97% -> 100%
 2025-12-01 20:15:40 +01:00
Krzysztof kuhy Rudnicki
4e64c3deef feat(tests): improve keyboard_coop test coverage to 97% 
- Add test for JSONDecodeError fallback dictionary loading
- Add test for game initialization (__init__)
- Add tests for handle_click on letter, enter button, and reset button
- Add tests for drawing methods (_draw_text_line, _draw_button, _draw_keyboard, _draw_ui)
- Add extensive tests for game loop (run) covering:
  - QUIT event handling
  - Mouse click events
  - ENTER key submission
  - R key reset
  - Letter key presses
  - Right click ignored
  - Special key ignored
  - Unknown event type ignored

Coverage improved from 58% to 97%. Remaining uncovered lines are:
- Line 351: Unreachable defensive code (force submit when no moves)
- Lines 398-404: Unreachable dead code (hover color branch)
 2025-12-01 20:10:41 +01:00
Krzysztof kuhy Rudnicki
92e15e8909 Improve lichess_bot utils.py test coverage to 100% 
- Add tests for _version_file_path environment override
- Add tests for missing and invalid version files
- Add tests for write failure error handling
 2025-12-01 20:02:05 +01:00
Krzysztof kuhy Rudnicki
7acb114fe4 Improve test coverage for multiple modules 
- scrape_website: 98% -> 100% (test download returning false)
- tag_divider: 44% -> 100% (test folder creation, image processing)
- extract_links: 61% -> 100% (test main() function directly)
- keyboard_coop: 22% -> 58% (test game logic methods)
 2025-12-01 19:59:11 +01:00
Krzysztof kuhy Rudnicki
5ef944abc9 Add tests for multiple python_pkg modules 
- download_cats: Test generate_cats functionality (100% coverage)
- keyboard_coop: Test keyboard_listener with mocked pynput (22% coverage)
- mock_server: Test mitmproxy request interceptor (100% coverage)
- random_jpg: Test JPEG generation with mocked Pillow (100% coverage)
- randomize_numbers: Test random_digits functions (99% coverage)
- scrape_website: Test scrape_comics with mocked requests (98% coverage)
- split: Test text splitting utilities (100% coverage)
- tag_divider: Test tag_divider with mock filesystem (44% coverage)
- extract_links: Add HTML fixture for tests
 2025-12-01 19:49:44 +01:00
Krzysztof kuhy Rudnicki
a3956d856b refactor: clean up pyproject.toml - remove defaults and redundant configs 2025-12-01 16:33:42 +01:00
Krzysztof kuhy Rudnicki
d24b005809 fix: remove all pylint disable comments and enable all meta checks 2025-12-01 16:22:03 +01:00
Krzysztof kuhy Rudnicki
81d6dd5315 fix: enable all pylint checks by wrapping scripts in main() 
- Remove too-few-public-methods and invalid-name from disabled checks
- Wrap module-level code in main() functions:
  - generate_jpeg.py
  - random_digits.py
  - generate_cats.py
  - scrape_comics.py
- Rename download_image -> _download_image (private function)

Pylint score: 10.00/10 with all checks enabled
 2025-12-01 16:15:03 +01:00
Krzysztof kuhy Rudnicki
0e73b27d50 fix: address all pylint warnings 
- R0914 (too many locals): Extract helper functions in generate_jpeg.py,
  engine.py, lichess_api.py, main.py
- R0902 (too many instance attributes): Use dataclasses in keyboard_coop
- W0621 (redefined outer name): Rename parameters/variables to avoid shadowing
- W0201 (attribute outside init): Initialize all attrs in __init__
- R1705 (no-else-return): Remove unnecessary else after return
- C1805 (implicit booleaness): Use implicit boolean checks
- R1732 (consider-using-with): Use context manager for subprocess.Popen
- E0401 (import-error): Add pylint disable for optional deps (selenium, mitmproxy)
- Clean up pyproject.toml: update comments, remove redundant settings

Pylint score: 10.00/10
 2025-12-01 16:11:15 +01:00
Krzysztof kuhy Rudnicki
8ecc13cb56 fix(lint): fix G004 and PTH123 violations across codebase 
- Convert f-string logging to % style (G004)
- Convert open() to Path.open() (PTH123)
- Remove G004 and PTH123 from global ignores in pyproject.toml
 2025-11-30 23:57:49 +01:00
Krzysztof kuhy Rudnicki
6f1dfb769f fix(lint): restore S603 noqa for trusted subprocess call 2025-11-30 23:49:57 +01:00
Krzysztof kuhy Rudnicki
1979089fcf fix(lint): fix S603 in engine.py and D100 in conftest.py 
- Add noqa: S603 for trusted internal C engine subprocess call
- Add module docstring to conftest.py
- Remove per-file ignores for engine.py and conftest.py from pyproject.toml
 2025-11-30 23:43:34 +01:00
Krzysztof kuhy Rudnicki
8aeee0d55a refactor(lichess_bot): reduce complexity with dataclasses and extracted functions 
- Add GameState, GameMeta, BotContext dataclasses for state bundling
- Extract 20+ helper functions from nested closures to module level
- Fix C901, PLR0912, PLR0915 complexity violations
- Fix mypy type errors with proper type annotations
- Add noqa for intentional S603 (subprocess call to trusted internal script)
 2025-11-30 23:40:53 +01:00
Krzysztof kuhy Rudnicki
da6271c438 refactor(stockfish_analysis): reduce complexity of main() function 
Break down monolithic main() into smaller, focused functions:
- _build_argument_parser(): CLI argument setup
- _load_game(): PGN file loading and parsing
- _configure_threads/hash/multipv/nnue(): Engine configuration helpers
- _setup_engine(): Engine initialization orchestration
- _get_best_move(): Engine best move extraction
- _evaluate_position(): Position evaluation wrapper
- _classify_mate_move(): Mate score classification logic
- _analyze_single_move(): Single move analysis
- _log_move_analysis(): Move analysis logging
- _run_analysis(): Analysis loop orchestration
- _analyze_last_move/all_moves(): Specific analysis modes

Add dataclasses MoveAnalysis and AnalysisContext to bundle related
parameters, improving code organization and reducing function signatures.

This removes the need for C901, PLR0912, PLR0915 per-file ignores
as all functions now comply with complexity limits.
 2025-11-30 23:23:10 +01:00
Krzysztof kuhy Rudnicki
d22619b483 fix(lint): convert os.path to pathlib - remove PTH per-file ignores 
- Converted os.path patterns to pathlib.Path in 15+ files
- os.path.join → Path /
- os.path.dirname → Path.parent
- os.path.exists → Path.exists()
- os.path.isfile → Path.is_file()
- os.path.abspath → Path.resolve()
- os.mkdir → Path.mkdir()
- os.listdir → Path.iterdir()
- os.getcwd → Path.cwd()
- os.replace → Path.replace()
- Updated function type hints to accept str | Path

Added PTH123 (open() vs Path.open()) to global ignores as stylistic preference
 2025-11-30 23:03:03 +01:00
Krzysztof kuhy Rudnicki
b1a5f245a2 fix(lint): LOG015 - replace root logger with module loggers 
- Add _logger = logging.getLogger(__name__) to all modules
- Replace logging.X() calls with _logger.X() calls
- Remove logging.basicConfig() from module level (keep in run_bot())
- Add G004 to global ignores (f-strings in logging are more readable)
- Remove LOG015 and G004 per-file ignores from pyproject.toml
- Fix pytest_ignore_collect hook signature in conftest.py
 2025-11-30 21:59:24 +01:00
Krzysztof kuhy Rudnicki
dd2da6e2cc fix(lint): BLE001 - replace blind except with specific exceptions 
Replace bare 'except Exception' with specific exception types:
- ValueError for move parsing (chess.Move.from_uci, board.push_uci)
- json.JSONDecodeError for JSON parsing
- OSError for file operations
- ImportError for optional imports
- AttributeError for attribute access
- TypeError for type-related operations
- requests.RequestException for HTTP operations
- subprocess.SubprocessError for subprocess failures
- selenium.NoSuchElementException for element finding

Also fixes:
- pytest hook signature issue in conftest.py (_config -> _)
- Missing file handling in test_puzzles.py
- Line length in stockfish_analysis.py

Removes all BLE001 per-file ignores from pyproject.toml.
 2025-11-30 21:37:47 +01:00
Krzysztof kuhy Rudnicki
b78f02cf05 fix: resolve PERF203 try-except in loop violations 
- Extract try-except bodies into helper functions:
  - download_cats: _download_single_image()
  - randomize_numbers: _parse_single_number()
  - lichess_bot/main: _apply_move_to_board(), _process_event_stream(), _run_event_loop_iteration()
- Use else block for return statements after try (TRY300)
- Remove PERF203 from per-file ignores in pyproject.toml
 2025-11-30 21:29:03 +01:00
Krzysztof kuhy Rudnicki
2dd4e68edb refactor: rename folders to fix N999, INP001, S311 linting rules 
- Rename PYTHON/ to python_pkg/ (fix N999 uppercase folder)
- Rename camelCase folders to snake_case:
  - randomJPG -> random_jpg
  - tagDivider -> tag_divider
  - downloadCats -> download_cats
  - keyboardCoop -> keyboard_coop
  - extractLinks -> extract_links
  - scapeWebsite -> scrape_website
- Rename camelCase files:
  - generateJpeg.py -> generate_jpeg.py
  - tagDivider.py -> tag_divider.py
- Rename poker-modifier-app to poker_modifier_app (fix INP001)
- Add __init__.py to poker_modifier_app
- Replace random module with secrets.SystemRandom (fix S311)
- Fix S110 try-except-pass with contextlib.suppress
- Update all imports and config references
 2025-11-30 21:20:17 +01:00