mirror of
https://github.com/kuhyx/todo-app.git
synced 2026-07-04 18:23:07 +02:00
Notes list & filtering: - Text-search filter plus independent date-range filters for both created and last-updated (AND-combined), a priority filter, and a new status filter. Default view hides Done/Abandoned and renders as "unfiltered" (no badge for the default state); fixed badge clipping. - NoteSort options wired into the list UI; watchCount() for the "N saved". Status & priority: - New Status enum (toDo/inProgress/Done/Abandoned) as a settable + filterable attribute on every note, with capture-screen dropdown. - Removed "None" priority: every note is Low/Medium/High, default Medium. Schema migration v2->v3 rewrites legacy priority 0 -> Medium. Export / import: - NotesMarkdown round-trippable single-file format with HTML-comment markers. - Settings "Export notes" (mobile share sheet / desktop writes ~/todo/BACKLOG.md) and "Import notes" (file picker + safe newer-wins merge by id). Structured template: - Every new note pre-fills the richer what/where/must/nice/out/done/depends/ estimate/refs scaffold. Tests: - New fast (~5s), deterministic suite via FakeNoteRepository (no DB timers) and injected http/file-selector/url-launcher fakes. 86 tests, 96.2% line coverage (note.dart & sync_service.dart at 100%, settings 98.7%). Mobile-only share branch excluded via coverage:ignore (unreachable on the Linux test host). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
147 lines
4.9 KiB
Dart
147 lines
4.9 KiB
Dart
import 'dart:async';
|
|
import 'dart:convert';
|
|
|
|
import 'package:http/http.dart' as http;
|
|
|
|
/// First-stage response of the GitHub OAuth Device Flow: the code the user
|
|
/// types on github.com and the URL to type it into.
|
|
class DeviceCodeResponse {
|
|
const DeviceCodeResponse({
|
|
required this.deviceCode,
|
|
required this.userCode,
|
|
required this.verificationUri,
|
|
required this.interval,
|
|
required this.expiresIn,
|
|
});
|
|
|
|
/// Opaque code the client polls with (not shown to the user).
|
|
final String deviceCode;
|
|
|
|
/// Short code the user enters on the verification page.
|
|
final String userCode;
|
|
|
|
/// Page the user opens to enter [userCode] (github.com/login/device).
|
|
final String verificationUri;
|
|
|
|
/// Minimum seconds to wait between polls.
|
|
final int interval;
|
|
|
|
/// Seconds until [deviceCode] expires.
|
|
final int expiresIn;
|
|
|
|
factory DeviceCodeResponse.fromJson(Map<String, dynamic> json) {
|
|
return DeviceCodeResponse(
|
|
deviceCode: json['device_code'] as String,
|
|
userCode: json['user_code'] as String,
|
|
verificationUri: json['verification_uri'] as String,
|
|
interval: (json['interval'] as int?) ?? 5,
|
|
expiresIn: (json['expires_in'] as int?) ?? 900,
|
|
);
|
|
}
|
|
}
|
|
|
|
/// Raised when the device-flow authorization fails or is declined.
|
|
class DeviceAuthException implements Exception {
|
|
DeviceAuthException(this.code, this.message);
|
|
|
|
/// GitHub error code, e.g. `access_denied`, `expired_token`.
|
|
final String code;
|
|
final String message;
|
|
|
|
@override
|
|
String toString() => 'DeviceAuthException($code): $message';
|
|
}
|
|
|
|
/// Implements the GitHub OAuth **Device Flow** so the user can authorize the
|
|
/// app by visiting a URL and entering a short code — no token pasting.
|
|
///
|
|
/// Device flow needs only a public `client_id` (no client secret), which
|
|
/// makes it safe for a distributed app. The resulting access token is then
|
|
/// used exactly like a PAT by [GitHubClient].
|
|
///
|
|
/// References:
|
|
/// - POST https://github.com/login/device/code
|
|
/// - POST https://github.com/login/oauth/access_token
|
|
class GitHubDeviceAuth {
|
|
GitHubDeviceAuth({
|
|
required this.clientId,
|
|
this.scope = 'repo',
|
|
http.Client? httpClient,
|
|
Future<void> Function(Duration)? delay,
|
|
}) : _http = httpClient ?? http.Client(),
|
|
// Indirection so tests can skip real waiting between polls.
|
|
_delay = delay ?? Future<void>.delayed;
|
|
|
|
final String clientId;
|
|
|
|
/// OAuth scope requested. `repo` is required for private-repo contents.
|
|
final String scope;
|
|
|
|
final http.Client _http;
|
|
final Future<void> Function(Duration) _delay;
|
|
|
|
static const _deviceCodeUrl = 'https://github.com/login/device/code';
|
|
static const _tokenUrl = 'https://github.com/login/oauth/access_token';
|
|
static const _grantType = 'urn:ietf:params:oauth:grant-type:device_code';
|
|
|
|
/// Step 1: ask GitHub for a device + user code.
|
|
Future<DeviceCodeResponse> requestDeviceCode() async {
|
|
final res = await _http.post(
|
|
Uri.parse(_deviceCodeUrl),
|
|
headers: const {'Accept': 'application/json'},
|
|
body: {'client_id': clientId, 'scope': scope},
|
|
);
|
|
if (res.statusCode != 200) {
|
|
throw DeviceAuthException('http_${res.statusCode}', res.body);
|
|
}
|
|
return DeviceCodeResponse.fromJson(
|
|
jsonDecode(res.body) as Map<String, dynamic>,
|
|
);
|
|
}
|
|
|
|
/// Step 2: poll until the user authorizes, returning the access token.
|
|
///
|
|
/// Honors GitHub's pacing protocol: `authorization_pending` keeps polling,
|
|
/// `slow_down` increases the interval, and terminal errors throw a
|
|
/// [DeviceAuthException].
|
|
Future<String> pollForToken(DeviceCodeResponse device) async {
|
|
var intervalSeconds = device.interval;
|
|
final deadline = DateTime.now().add(Duration(seconds: device.expiresIn));
|
|
|
|
while (DateTime.now().isBefore(deadline)) {
|
|
await _delay(Duration(seconds: intervalSeconds));
|
|
final res = await _http.post(
|
|
Uri.parse(_tokenUrl),
|
|
headers: const {'Accept': 'application/json'},
|
|
body: {
|
|
'client_id': clientId,
|
|
'device_code': device.deviceCode,
|
|
'grant_type': _grantType,
|
|
},
|
|
);
|
|
final json = jsonDecode(res.body) as Map<String, dynamic>;
|
|
|
|
final token = json['access_token'] as String?;
|
|
if (token != null) return token;
|
|
|
|
switch (json['error'] as String?) {
|
|
case 'authorization_pending':
|
|
continue; // User has not finished authorizing yet.
|
|
case 'slow_down':
|
|
// GitHub asks us to back off; obey its new interval.
|
|
intervalSeconds = (json['interval'] as int?) ?? intervalSeconds + 5;
|
|
case final String error:
|
|
throw DeviceAuthException(
|
|
error,
|
|
(json['error_description'] as String?) ?? error,
|
|
);
|
|
case null:
|
|
throw DeviceAuthException('unknown', 'Unexpected response: $json');
|
|
}
|
|
}
|
|
throw DeviceAuthException('expired_token', 'Device code expired.');
|
|
}
|
|
|
|
void close() => _http.close();
|
|
}
|