mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-07-04 19:23:10 +02:00
Krzysztof kuhy Rudnicki
ee27d10fef
Fix ruff violations in ~15 source files and ~60+ test files to minimize per-file-ignores in pyproject.toml. Remaining ignores are justified with comments explaining why each suppression is necessary. Source fixes: FBT003 (keyword args), S310 (URL validation), SLF001 (private access), T201 (print→logging), C901 (complexity), E501 (line length), E402 (import order). Test fixes: SIM117 (combined with), FBT (boolean args), PERF203 (try in loop), S310/S607 (URLs/executables), E402/E501 (imports/lines), S108 (tmp paths), PLR0913 (too many args), ARG (unused args), ANN (type annotations), RUF059 (unused unpacked vars), PT019 (fixture naming). Remaining per-file-ignores (with justifications): - Tests: ARG, D, PLC0415, PLR2004, S101, SLF001 - music_gen sources: PLC0415 (heavy ML lazy imports) - moviepy_showcase: PLC0415 (circular dependency) - generate_images: PLR0913 (matplotlib helpers need many params) - praca_magisterska_video: E501, E402 (long paths, mpl.use)
269 lines
9.4 KiB
Python
269 lines
9.4 KiB
Python
"""Tests for phone verification coverage gaps (part 2)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from python_pkg.screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestGetWirelessSerial:
|
|
"""Tests for _get_wireless_serial method."""
|
|
|
|
def test_returns_wireless_serial(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns ip:port serial for a wireless device."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
output = "List of devices attached\n192.168.1.42:5555\tdevice\n"
|
|
with patch.object(locker, "_run_adb", return_value=(True, output)):
|
|
result = locker._get_wireless_serial()
|
|
assert result == "192.168.1.42:5555"
|
|
|
|
def test_returns_none_when_adb_fails(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns None when adb devices fails."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(locker, "_run_adb", return_value=(False, "")):
|
|
result = locker._get_wireless_serial()
|
|
assert result is None
|
|
|
|
def test_returns_none_when_no_wireless_device(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns None when only USB devices are connected."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
output = "List of devices attached\nABC123DEF456\tdevice\n"
|
|
with patch.object(locker, "_run_adb", return_value=(True, output)):
|
|
result = locker._get_wireless_serial()
|
|
assert result is None
|
|
|
|
def test_skips_offline_wireless_device(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test skips offline wireless devices."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
output = "List of devices attached\n192.168.1.42:5555\toffline\n"
|
|
with patch.object(locker, "_run_adb", return_value=(True, output)):
|
|
result = locker._get_wireless_serial()
|
|
assert result is None
|
|
|
|
|
|
class TestTryAdbConnect:
|
|
"""Tests for _try_adb_connect method."""
|
|
|
|
def test_successful_connect(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test successful ADB connect."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(
|
|
locker, "_run_adb", return_value=(True, "connected to 192.168.1.42:5555")
|
|
):
|
|
result = locker._try_adb_connect("192.168.1.42:5555")
|
|
assert result is True
|
|
|
|
def test_failed_connect_unable(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test connect failure with 'unable' in output."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(
|
|
locker, "_run_adb", return_value=(False, "unable to connect")
|
|
):
|
|
result = locker._try_adb_connect("192.168.1.42:5555")
|
|
assert result is False
|
|
|
|
def test_failed_connect_with_failed(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test connect failure with 'failed' in output."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(
|
|
locker,
|
|
"_run_adb",
|
|
return_value=(False, "connected but failed to authenticate"),
|
|
):
|
|
result = locker._try_adb_connect("192.168.1.42:5555")
|
|
assert result is False
|
|
|
|
def test_no_connected_in_output(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test connect failure when 'connected' not in output."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(
|
|
locker, "_run_adb", return_value=(False, "some random output")
|
|
):
|
|
result = locker._try_adb_connect("192.168.1.42:5555")
|
|
assert result is False
|
|
|
|
|
|
class TestGetLocalSubnetPrefix:
|
|
"""Tests for _get_local_subnet_prefix method."""
|
|
|
|
def test_returns_prefix(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns first three octets of local IP."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_sock = MagicMock()
|
|
mock_sock.getsockname.return_value = ("192.168.1.100", 12345)
|
|
mock_sock.__enter__ = MagicMock(return_value=mock_sock)
|
|
mock_sock.__exit__ = MagicMock(return_value=False)
|
|
with patch(
|
|
"python_pkg.screen_locker._phone_verification.socket.socket",
|
|
return_value=mock_sock,
|
|
):
|
|
result = locker._get_local_subnet_prefix()
|
|
assert result == "192.168.1"
|
|
|
|
def test_returns_none_on_oserror(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns None when socket raises OSError."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch(
|
|
"python_pkg.screen_locker._phone_verification.socket.socket",
|
|
side_effect=OSError("no network"),
|
|
):
|
|
result = locker._get_local_subnet_prefix()
|
|
assert result is None
|
|
|
|
|
|
class TestTryWirelessReconnect:
|
|
"""Tests for _try_wireless_reconnect method."""
|
|
|
|
def test_returns_false_when_no_prefix(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns False when subnet prefix can't be determined."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(locker, "_get_local_subnet_prefix", return_value=None):
|
|
result = locker._try_wireless_reconnect()
|
|
assert result is False
|
|
|
|
def test_returns_true_when_probe_succeeds(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns True when a probe finds the phone."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_get_local_subnet_prefix", return_value="192.168.1"),
|
|
patch.object(locker, "_try_adb_connect", return_value=True),
|
|
patch.object(locker, "_has_adb_device", return_value=True),
|
|
patch(
|
|
"python_pkg.screen_locker._phone_verification.socket.create_connection",
|
|
) as mock_conn,
|
|
):
|
|
mock_sock = MagicMock()
|
|
mock_sock.__enter__ = MagicMock(return_value=mock_sock)
|
|
mock_sock.__exit__ = MagicMock(return_value=False)
|
|
mock_conn.return_value = mock_sock
|
|
result = locker._try_wireless_reconnect()
|
|
assert result is True
|
|
|
|
def test_returns_false_when_no_probe_succeeds(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns False when no probe finds the phone."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_get_local_subnet_prefix", return_value="192.168.1"),
|
|
patch(
|
|
"python_pkg.screen_locker._phone_verification.socket.create_connection",
|
|
side_effect=OSError("refused"),
|
|
),
|
|
):
|
|
result = locker._try_wireless_reconnect()
|
|
assert result is False
|
|
|
|
def test_probe_connect_succeeds_but_no_device(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test probe passes socket but adb_connect succeeds without device."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_get_local_subnet_prefix", return_value="192.168.1"),
|
|
patch.object(locker, "_try_adb_connect", return_value=True),
|
|
patch.object(locker, "_has_adb_device", return_value=False),
|
|
patch(
|
|
"python_pkg.screen_locker._phone_verification.socket.create_connection",
|
|
) as mock_conn,
|
|
):
|
|
mock_sock = MagicMock()
|
|
mock_sock.__enter__ = MagicMock(return_value=mock_sock)
|
|
mock_sock.__exit__ = MagicMock(return_value=False)
|
|
mock_conn.return_value = mock_sock
|
|
result = locker._try_wireless_reconnect()
|
|
assert result is False
|
|
|
|
def test_probe_adb_connect_fails(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test probe where socket connects but adb connect fails."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_get_local_subnet_prefix", return_value="192.168.1"),
|
|
patch.object(locker, "_try_adb_connect", return_value=False),
|
|
patch(
|
|
"python_pkg.screen_locker._phone_verification.socket.create_connection",
|
|
) as mock_conn,
|
|
):
|
|
mock_sock = MagicMock()
|
|
mock_sock.__enter__ = MagicMock(return_value=mock_sock)
|
|
mock_sock.__exit__ = MagicMock(return_value=False)
|
|
mock_conn.return_value = mock_sock
|
|
result = locker._try_wireless_reconnect()
|
|
assert result is False
|