testsAndMisc/docs/superpowers/contracts/diet-guard-meal-and-trigger-fix-2026-06-10.json
Krzysztof kuhy Rudnicki 31992b2a90 feat(diet_guard): add meal-logging screen-lock gate with trigger fix
Add the diet_guard package: a screen-locking meal-logging gate that fires
on 4-hour slots (08/12/16/20) and records calories/macros, persisting an
autocompleting food bank.

- Trigger fix: the systemd timer fires at session start (Persistent=true)
  before lightdm has written ~/.Xauthority, so the gate crashed with a
  TclError instead of locking the screen. Add wait_for_display() /
  _display_is_ready() in _gatelock.py and wire it into _cli._cmd_gate so the
  gate retries on the next tick instead of crashing; add
  Environment=XAUTHORITY=%h/.Xauthority to the service as belt-and-suspenders.
- Food-bank hardening: a transiently corrupt food_bank.json was warned about
  on every keystroke and then silently overwritten (data loss). _read_bank
  now quarantines it via _quarantine_corrupt_bank() (warn-once + timestamped
  backup) before starting fresh.
- Multi-item meals: new _meal.py (MealItem, meal_total, MEAL_SOURCE),
  remember_meal() + _upsert() in _foodbank.py, and a "+ Add item" control in
  the gate that logs both the individual items and the composite meal.
- Bundle resolve_nutrition's manual macros into a ManualMacros dataclass to
  stay within the argument-count limit.

diet_guard at 100% branch coverage; full pre-commit suite passes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-10 22:32:39 +02:00

17 lines
1.6 KiB
JSON

{
"title": "diet_guard: screen-lock meal gate with trigger fix, food-bank hardening, and multi-item meals",
"objective": "Land the diet_guard package so the 4-hour meal-logging gate reliably locks the screen at slot time, no longer crashes when the systemd timer fires before X authorization is ready, no longer floods/overwrites a corrupt food bank, and supports logging a composite meal made of several separately-macroed items. Success = the package is committed, all pre-commit gates pass, and diet_guard holds 100% branch coverage.",
"acceptance_criteria": [
"The gate retries instead of raising TclError when the display is not yet authorized at session start (wait_for_display in _gatelock.py, wired into _cli._cmd_gate).",
"A corrupt food_bank.json is moved aside with a timestamped backup and warned about once, never silently overwritten.",
"A meal of multiple items records each item plus a composite total (kcal/macros summed) to the food bank, surfaced via a '+ Add item' control in the gate.",
"diet_guard reports 100% branch coverage and the full pre-commit suite (ruff, ruff-format, mypy, pylint, bandit, codespell, no-noqa, pytest-coverage) passes."
],
"out_of_scope": [
"Changes to other python_pkg packages (wake_alarm, etc.) — excluded from this commit.",
"Resolving the unrelated dirty working-tree edits to wake_alarm and the dwm/gaming scripts.",
"Real-world reboot confirmation of the display-race fix and human visual review of the meal UI layout."
],
"verifier": "pre-commit run --files <diet_guard files> (run from a clean worktree); pytest_changed_packages.py enforces --cov-fail-under=100 across python_pkg"
}