testsAndMisc/python_pkg/brother_printer/tests/test_cups_queue_part2.py
Krzysztof kuhy Rudnicki ee27d10fef Reduce per-file-ignores by fixing lint violations across codebase
Fix ruff violations in ~15 source files and ~60+ test files to minimize
per-file-ignores in pyproject.toml. Remaining ignores are justified with
comments explaining why each suppression is necessary.

Source fixes: FBT003 (keyword args), S310 (URL validation), SLF001
(private access), T201 (print→logging), C901 (complexity), E501 (line
length), E402 (import order).

Test fixes: SIM117 (combined with), FBT (boolean args), PERF203 (try in
loop), S310/S607 (URLs/executables), E402/E501 (imports/lines), S108
(tmp paths), PLR0913 (too many args), ARG (unused args), ANN (type
annotations), RUF059 (unused unpacked vars), PT019 (fixture naming).

Remaining per-file-ignores (with justifications):
- Tests: ARG, D, PLC0415, PLR2004, S101, SLF001
- music_gen sources: PLC0415 (heavy ML lazy imports)
- moviepy_showcase: PLC0415 (circular dependency)
- generate_images: PLR0913 (matplotlib helpers need many params)
- praca_magisterska_video: E501, E402 (long paths, mpl.use)
2026-03-25 18:58:05 +01:00

279 lines
11 KiB
Python

"""Tests for brother_printer.cups_queue module - part 2 (interactive fix)."""
from __future__ import annotations
from io import StringIO
from unittest.mock import MagicMock, patch
from python_pkg.brother_printer.cups_queue import (
_dwj_cancel_and_enable,
_dwj_cancel_only,
_dwj_enable_only,
_dwj_restart_and_enable,
_dwj_restart_only,
_handle_backend_errors_only,
_handle_disabled_no_jobs,
_handle_disabled_with_jobs,
_handle_enabled_with_jobs,
_offer_queue_fix,
)
from python_pkg.brother_printer.data_classes import CUPSJob, CUPSQueueStatus
MOD = "python_pkg.brother_printer.cups_queue"
# ── _offer_queue_fix ─────────────────────────────────────────────────
class TestOfferQueueFix:
"""Tests for _offer_queue_fix menu routing."""
@patch(f"{MOD}._handle_disabled_with_jobs")
@patch(f"{MOD}._prompt", return_value="1")
def test_disabled_with_jobs(self, p: MagicMock, mock_handler: MagicMock) -> None:
queue = CUPSQueueStatus(
printer_name="B",
enabled=False,
jobs=[CUPSJob("j1", "alice", "1024", "Mon")],
)
with patch("sys.stdout", new_callable=StringIO):
_offer_queue_fix(queue)
mock_handler.assert_called_once_with(queue, "1")
@patch(f"{MOD}._handle_disabled_no_jobs")
@patch(f"{MOD}._prompt", return_value="2")
def test_disabled_no_jobs(self, p: MagicMock, mock_handler: MagicMock) -> None:
queue = CUPSQueueStatus(printer_name="B", enabled=False)
with patch("sys.stdout", new_callable=StringIO):
_offer_queue_fix(queue)
mock_handler.assert_called_once_with(queue, "2")
@patch(f"{MOD}._handle_enabled_with_jobs")
@patch(f"{MOD}._prompt", return_value="1")
def test_enabled_with_jobs(self, p: MagicMock, mock_handler: MagicMock) -> None:
queue = CUPSQueueStatus(
printer_name="B",
enabled=True,
jobs=[CUPSJob("j1", "alice", "1024", "Mon")],
)
with patch("sys.stdout", new_callable=StringIO):
_offer_queue_fix(queue)
mock_handler.assert_called_once_with(queue, "1")
@patch(f"{MOD}._handle_backend_errors_only")
@patch(f"{MOD}._prompt", return_value="1")
def test_backend_errors_only(self, p: MagicMock, mock_handler: MagicMock) -> None:
queue = CUPSQueueStatus(printer_name="B", enabled=True)
with patch("sys.stdout", new_callable=StringIO):
_offer_queue_fix(queue)
mock_handler.assert_called_once_with("1")
# ── _dwj_* action functions ─────────────────────────────────────────
class TestDwjEnableOnly:
@patch(f"{MOD}._cups_enable_printer", return_value=True)
def test_success(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_enable_only("B")
@patch(f"{MOD}._cups_enable_printer", return_value=False)
def test_failure(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_enable_only("B")
class TestDwjCancelAndEnable:
@patch(f"{MOD}._cups_enable_printer", return_value=True)
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=True)
def test_success(self, c: MagicMock, e: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_cancel_and_enable("B")
@patch(f"{MOD}._cups_enable_printer", return_value=False)
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=True)
def test_enable_fails(self, c: MagicMock, e: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_cancel_and_enable("B")
class TestDwjCancelOnly:
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=True)
def test_success(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_cancel_only("B")
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=False)
def test_failure(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_cancel_only("B")
class TestDwjRestartOnly:
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_success(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_restart_only("B")
@patch(f"{MOD}._cups_restart_service", return_value=False)
def test_failure(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_restart_only("B")
class TestDwjRestartAndEnable:
@patch(f"{MOD}._cups_enable_printer", return_value=True)
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_success(self, r: MagicMock, e: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_restart_and_enable("B")
@patch(f"{MOD}._cups_restart_service", return_value=False)
def test_restart_fails(self, r: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_dwj_restart_and_enable("B")
# ── _handle_disabled_with_jobs ───────────────────────────────────────
class TestHandleDisabledWithJobs:
"""Tests for _handle_disabled_with_jobs dispatch."""
def _make_queue(self) -> CUPSQueueStatus:
return CUPSQueueStatus(
printer_name="B",
enabled=False,
jobs=[CUPSJob("j1", "alice", "1024", "Mon")],
)
@patch(f"{MOD}._cups_enable_printer", return_value=True)
def test_choice_1(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "1")
@patch(f"{MOD}._cups_enable_printer", return_value=True)
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=True)
def test_choice_2(self, c: MagicMock, e: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "2")
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=True)
def test_choice_3(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "3")
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_choice_4(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "4")
@patch(f"{MOD}._cups_enable_printer", return_value=True)
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_choice_5(self, r: MagicMock, e: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "5")
def test_choice_6_no_action(self) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "6")
def test_invalid_choice(self) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_with_jobs(self._make_queue(), "99")
# ── _handle_disabled_no_jobs ─────────────────────────────────────────
class TestHandleDisabledNoJobs:
"""Tests for _handle_disabled_no_jobs."""
def _make_queue(self) -> CUPSQueueStatus:
return CUPSQueueStatus(printer_name="B", enabled=False)
@patch(f"{MOD}._cups_enable_printer", return_value=True)
def test_choice_1_enable(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_no_jobs(self._make_queue(), "1")
@patch(f"{MOD}._cups_enable_printer", return_value=False)
def test_choice_1_enable_fails(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_no_jobs(self._make_queue(), "1")
@patch(f"{MOD}._cups_enable_printer", return_value=True)
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_choice_2_restart(self, r: MagicMock, e: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_no_jobs(self._make_queue(), "2")
@patch(f"{MOD}._cups_restart_service", return_value=False)
def test_choice_2_restart_fails(self, r: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_no_jobs(self._make_queue(), "2")
def test_choice_3_no_action(self) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_disabled_no_jobs(self._make_queue(), "3")
# ── _handle_enabled_with_jobs ────────────────────────────────────────
class TestHandleEnabledWithJobs:
"""Tests for _handle_enabled_with_jobs."""
def _make_queue(self) -> CUPSQueueStatus:
return CUPSQueueStatus(
printer_name="B",
enabled=True,
jobs=[CUPSJob("j1", "alice", "1024", "Mon")],
)
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=True)
def test_choice_1_cancel(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_enabled_with_jobs(self._make_queue(), "1")
@patch(f"{MOD}._cups_cancel_all_jobs", return_value=False)
def test_choice_1_cancel_fails(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_enabled_with_jobs(self._make_queue(), "1")
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_choice_2_restart(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_enabled_with_jobs(self._make_queue(), "2")
@patch(f"{MOD}._cups_restart_service", return_value=False)
def test_choice_2_restart_fails(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_enabled_with_jobs(self._make_queue(), "2")
def test_choice_3_no_action(self) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_enabled_with_jobs(self._make_queue(), "3")
# ── _handle_backend_errors_only ──────────────────────────────────────
class TestHandleBackendErrorsOnly:
"""Tests for _handle_backend_errors_only."""
@patch(f"{MOD}._cups_restart_service", return_value=True)
def test_choice_1_restart(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_backend_errors_only("1")
@patch(f"{MOD}._cups_restart_service", return_value=False)
def test_choice_1_restart_fails(self, m: MagicMock) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_backend_errors_only("1")
def test_choice_2_no_action(self) -> None:
with patch("sys.stdout", new_callable=StringIO):
_handle_backend_errors_only("2")