mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-07-04 13:03:13 +02:00
Krzysztof kuhy Rudnicki
038e08d2be
Split diet_guard/_gatelock.py, wake_alarm/_alarm.py, and the usage_report.py/_usage_report_parsing.py pair into focused sub-modules so every Python file is <= 500 lines, satisfying test_file_length.py. Install python-kasa into .venv (declared in requirements but missing after the 3.13->3.14 venv upgrade), fixing 8 failing smart_plug tests and restoring 100% coverage. Also includes prior in-progress work from the working tree: the wake_alarm Progress/View/Hardware field-grouping refactor, brother_printer query module + tests, diet_guard foodbank/state/cli updates, new shared coerce/logging_setup helpers, morning_routine orchestrator tweaks, dwm window-manager config, gaming scripts, and misc maintenance/digital-wellbeing script updates. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
19 lines
2.0 KiB
JSON
19 lines
2.0 KiB
JSON
{
|
|
"title": "Dedupe validate_contract/validate_evidence to reach pylint 10/10",
|
|
"objective": "validate_contract.py and validate_evidence.py shared near-identical required-key/string-list/CLI-dispatch logic, triggering 3x pylint R0801 duplicate-code findings. This was the last of 16 findings blocking the repo-wide pylint pre-commit hook from reaching --fail-under=10. Extract the shared logic into a new _schema_validation.py helper module so both scripts import it, eliminating the duplication while preserving identical CLI behaviour (success/error messages, exit codes).",
|
|
"acceptance_criteria": [
|
|
"meta/scripts/_schema_validation.py provides is_nonempty_str, load_and_check_required, check_string_lists, run_cli",
|
|
"validate_contract.py and validate_evidence.py import and use these helpers instead of duplicating the logic",
|
|
"pylint --rcfile=meta/pyproject.toml on the 3 files scores 10.00/10 with zero duplicate-code findings",
|
|
"pre-commit run pylint --all-files passes repo-wide (the overarching --fail-under=10 goal)",
|
|
"validate_contract.py and validate_evidence.py produce identical stdout/stderr/exit codes for: valid artifact, missing file, missing argv",
|
|
"linux_configuration/tests/test_validate_contract.py and test_validate_evidence.py pass unchanged"
|
|
],
|
|
"out_of_scope": [
|
|
"Any other staged/unstaged changes already present in the working tree (dwm setup, gaming scripts, transcription tools, usage-report edits, etc.)",
|
|
"python_pkg/tests/test_file_length.py 500-line violations (pre-existing, separate issue)",
|
|
"Changing error-message wording in _check_required_keys/_check_strings/_check_intent/_check_verification/_check_phrases"
|
|
],
|
|
"verifier": "pylint --rcfile=meta/pyproject.toml meta/scripts/_schema_validation.py meta/scripts/validate_contract.py meta/scripts/validate_evidence.py; pre-commit run pylint --all-files; python3 -m pytest linux_configuration/tests/test_validate_contract.py linux_configuration/tests/test_validate_evidence.py -q"
|
|
}
|