mirror of
https://github.com/kuhyx/testsAndMisc.git
synced 2026-07-04 15:23:03 +02:00
Krzysztof kuhy Rudnicki
63354a9e2e
Four bugs fixed: - HLTB search returned 0 results for ~87 games with special chars (™, ®, &, standalone -, (Legacy), RHCP, etc.) — add _sanitize_search_name() and extend _build_search_variants() with Steam-suffix and edition stripping - fetch_hltb_detail_missing returned immediately because `app_id not in rush` was always False (all keys present with -1) — fix to `rush.get(id,-1) <= 0` - save_hltb_cache overwrote rush/leisure on confidence-only partial saves — now reads existing cache and preserves data when extras dicts are empty - _filter_qualifying_games excluded 57 games with stale snapshot hours (-1) even though HLTB hours cache had valid data — add cache fallback Result: stats shows Rush 64,670h / Leisure 136,807h / Worst 228,594h for all 785 qualifying games with full rush+leisure detail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
38 lines
1.9 KiB
JSON
38 lines
1.9 KiB
JSON
{
|
|
"intent": "Fix steam_backlog_enforcer stats command to show real Rush/Leisure/Worst data for all qualifying games.",
|
|
"scope": [
|
|
"python_pkg/steam_backlog_enforcer/_hltb_search.py",
|
|
"python_pkg/steam_backlog_enforcer/_hltb_types.py",
|
|
"python_pkg/steam_backlog_enforcer/hltb.py",
|
|
"python_pkg/steam_backlog_enforcer/_stats.py",
|
|
"python_pkg/steam_backlog_enforcer/tests/"
|
|
],
|
|
"changes": [
|
|
"_hltb_search: sanitize game names before search (strip TM/R/C/fullwidth-asterisk, replace & with and, filter standalone punctuation)",
|
|
"_hltb_search: extend _build_search_variants with Steam-suffix stripping (Legacy, RHCP, Classic, beta) and chained edition+subtitle simplifications",
|
|
"hltb: fix fetch_hltb_detail_missing — changed `app_id not in rush` to `rush.get(app_id, -1) <= 0` (presence check was wrong)",
|
|
"_hltb_types: fix save_hltb_cache to preserve rush/leisure/game_id from existing cache on partial (confidence-only) saves",
|
|
"_stats: use HLTB hours cache as fallback when snapshot completionist_hours is stale (-1)"
|
|
],
|
|
"verification": [
|
|
{
|
|
"command": "python -m steam_backlog_enforcer stats",
|
|
"result": "pass",
|
|
"evidence": "Detail data: rush + leisure available for all 785 qualifying games. Rush: 64670h, Leisure: 136807h, Worst: 228594h"
|
|
},
|
|
{
|
|
"command": "pre-commit run --files <changed-files>",
|
|
"result": "pass",
|
|
"evidence": "All hooks passed including ruff, mypy, pylint, bandit, pytest-coverage (700 tests, 100% branch coverage)"
|
|
}
|
|
],
|
|
"risks": [
|
|
"HLTB name sanitization may over-strip edge-case game names — mitigated by variant fallback chain",
|
|
"save_hltb_cache partial-save preservation reads disk on every confidence save — minor I/O overhead"
|
|
],
|
|
"rollback": [
|
|
"Revert commits; delete hltb_cache.json to force re-fetch with old logic",
|
|
"Validate by running stats command and checking Rush/Leisure/Worst totals"
|
|
]
|
|
}
|