From 7945d384c51267f332da5e25471ef2ce49fb8664 Mon Sep 17 00:00:00 2001
From: Krzysztof kuhy Rudnicki <krzysztofrudnicki0@gmail.com>
Date: Sun, 12 Apr 2026 21:55:34 +0200
Subject: [PATCH] Fix fm24_searcher: restore CLI output and fix test mocking

- cli.py: restore _print_stats output using sys.stdout.write
- cli.py: restore run_dump output (player list, TSV, progress to stderr)
- cli.py: run_dump shows 'Showing X of Y players' summary
- test_main.py: patch __main__.run_dump/main not cli.run_dump/gui.main
---
 python_pkg/fm24_searcher/cli.py             | 36 ++++++++++++++-------
 python_pkg/fm24_searcher/tests/test_main.py |  4 +--
 2 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/python_pkg/fm24_searcher/cli.py b/python_pkg/fm24_searcher/cli.py
index e5e42d1..2b037ee 100644
--- a/python_pkg/fm24_searcher/cli.py
+++ b/python_pkg/fm24_searcher/cli.py
@@ -15,6 +15,7 @@ from __future__ import annotations
 
 import argparse
 from pathlib import Path
+import sys
 from typing import TYPE_CHECKING
 
 from python_pkg.fm24_searcher.binary_parser import (
@@ -159,25 +160,32 @@ def build_parser() -> argparse.ArgumentParser:
 def _print_stats(players: list[Player]) -> None:
     """Print summary statistics about loaded players."""
     total = len(players)
-    sum(1 for p in players if p.date_of_birth)
+    with_dob = sum(1 for p in players if p.date_of_birth)
     with_attrs = sum(1 for p in players if p.attributes)
-    sum(1 for p in players if p.current_ability)
+    with_ca = sum(1 for p in players if p.current_ability)
+    sys.stdout.write(f"Total players: {total}\n")
+    sys.stdout.write(f"With DOB: {with_dob}\n")
+    sys.stdout.write(f"With attributes: {with_attrs}\n")
+    sys.stdout.write(f"With CA/PA: {with_ca}\n")
     if with_attrs > 0:
-        sum(len(p.attributes) for p in players) / with_attrs
+        avg_attrs = sum(len(p.attributes) for p in players) / with_attrs
+        sys.stdout.write(f"Avg attributes per player: {avg_attrs:.1f}\n")
     if total == 0:
         return
-    if with_attrs > 0:
-        pass
     # Attribute coverage
     attr_counts: dict[str, int] = {}
     for p in players:
         for attr in p.attributes:
             attr_counts[attr] = attr_counts.get(attr, 0) + 1
     if attr_counts:
+        sys.stdout.write("Attribute coverage:\n")
         for attr in ALL_VISIBLE_ATTRS:
             count = attr_counts.get(attr, 0)
             pct = 100 * count / with_attrs if with_attrs else 0
-            "*" * int(pct / 5)
+            bar = "*" * int(pct / 5)
+            sys.stdout.write(
+                f"  {attr:20s} {count:4d}/{with_attrs:4d} ({pct:5.1f}%) {bar}\n"
+            )
 
 
 def run_dump(argv: Sequence[str] | None = None) -> int:
@@ -193,9 +201,11 @@ def run_dump(argv: Sequence[str] | None = None) -> int:
         return 2
 
     def progress(msg: str, pct: int) -> None:
-        pass
+        sys.stderr.write(f"\r{msg} {pct}%")
+        sys.stderr.flush()
 
     players = parse_people_db(db_path, progress_cb=progress)
+    sys.stderr.write("\n")
 
     if args.search:
         players = search_players(players, args.search)
@@ -209,13 +219,17 @@ def run_dump(argv: Sequence[str] | None = None) -> int:
 
     # Apply limit
     limited = players[: args.limit]
+    total = len(players)
+    shown = len(limited)
 
     # Output
     if args.tsv:
-        for _p in limited:
-            pass
+        sys.stdout.write(_format_tsv_header(show_attrs=args.attrs) + "\n")
+        for p in limited:
+            sys.stdout.write(_format_tsv_row(p, show_attrs=args.attrs) + "\n")
     else:
-        for _p in limited:
-            pass
+        for p in limited:
+            sys.stdout.write(_format_player(p, show_attrs=args.attrs) + "\n\n")
 
+    sys.stdout.write(f"Showing {shown} of {total} players\n")
     return 0
diff --git a/python_pkg/fm24_searcher/tests/test_main.py b/python_pkg/fm24_searcher/tests/test_main.py
index f11fd45..c56452c 100644
--- a/python_pkg/fm24_searcher/tests/test_main.py
+++ b/python_pkg/fm24_searcher/tests/test_main.py
@@ -16,7 +16,7 @@ class TestMain:
         with (
             patch("sys.argv", ["fm24", "--dump", "--db", "/nonexistent"]),
             patch(
-                "python_pkg.fm24_searcher.cli.run_dump",
+                "python_pkg.fm24_searcher.__main__.run_dump",
                 return_value=0,
             ) as mock_dump,
         ):
@@ -29,7 +29,7 @@ class TestMain:
         with (
             patch("sys.argv", ["fm24"]),
             patch(
-                "python_pkg.fm24_searcher.gui.main",
+                "python_pkg.fm24_searcher.__main__.main",
             ) as mock_gui,
         ):
             _main()