From c828aafdf9fe7e9721fbf65fce286b856d2e4ce0 Mon Sep 17 00:00:00 2001 From: Krzysztof kuhy Rudnicki Date: Fri, 8 May 2026 20:34:29 +0200 Subject: [PATCH] fix: remove dead code in unplayable_reason; add coverage for playable path --- steam_backlog_enforcer/protondb.py | 6 ++---- steam_backlog_enforcer/tests/test_protondb.py | 4 ++++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/steam_backlog_enforcer/protondb.py b/steam_backlog_enforcer/protondb.py index 10d4c6a..cdb29a7 100644 --- a/steam_backlog_enforcer/protondb.py +++ b/steam_backlog_enforcer/protondb.py @@ -90,7 +90,7 @@ class ProtonDBRating: return "" tier_rank = TIER_ORDER.get(self.tier, 99) - min_rank = TIER_ORDER[MIN_PLAYABLE_TIER] + TIER_ORDER[MIN_PLAYABLE_TIER] silver_rank = TIER_ORDER["silver"] if not self.trending_tier: @@ -99,9 +99,7 @@ class ProtonDBRating: trend_rank = TIER_ORDER.get(self.trending_tier, 99) if tier_rank > silver_rank or trend_rank > silver_rank: return f"below silver ({self.tier}/{self.trending_tier})" - if tier_rank > min_rank and trend_rank > min_rank: - return f"no gold tier ({self.tier}/{self.trending_tier})" - return "fails ProtonDB rule" + return f"no gold tier ({self.tier}/{self.trending_tier})" def _load_cache() -> dict[str, Any]: diff --git a/steam_backlog_enforcer/tests/test_protondb.py b/steam_backlog_enforcer/tests/test_protondb.py index bd581e1..2a0caa1 100644 --- a/steam_backlog_enforcer/tests/test_protondb.py +++ b/steam_backlog_enforcer/tests/test_protondb.py @@ -100,6 +100,10 @@ class TestProtonDBRating: r = ProtonDBRating(app_id=1, tier="gold", trending_tier="bronze") assert "below silver" in r.unplayable_reason + def test_unplayable_reason_empty_when_playable(self) -> None: + r = ProtonDBRating(app_id=1, tier="gold") + assert r.unplayable_reason == "" + class TestProtonDBCache: """Tests for cache I/O."""