fix: resolve all shellcheck errors

- Replace 'A && B || C' patterns with proper if-then-else statements (SC2015)
- Add check_for_virtualbox function to invoke prompt_for_virtualbox_challenge (SC2317)
- Fix install_launcher function to escape variable in heredoc (SC2119/SC2120)
- Apply shfmt formatting to ensure consistent style

Fixes 7 SC2015 violations, 1 SC2317 violation, and 1 SC2119/SC2120 pair.
All 79 shell files now pass shellcheck without errors.

fresh-install/install_amd_driver.sh

@@ -26,7 +26,7 @@ AMD_ENABLE_SI_CIK=${AMD_ENABLE_SI_CIK:-auto}
 AMD_SKIP_INITRAMFS=${AMD_SKIP_INITRAMFS:-0}
 AMD_VERBOSE=${AMD_VERBOSE:-0}
 
-vlog() { [ "$AMD_VERBOSE" = 1 ] && echo "[amd] $*" || true; }
+vlog() { if [ "$AMD_VERBOSE" = 1 ]; then echo "[amd] $*"; fi; }
 info() { echo "[amd] $*"; }
 warn() { echo "[amd][warn] $*" >&2; }
 

fresh-install/install_intel_driver.sh

@@ -26,7 +26,7 @@ INTEL_ENABLE_GUC=${INTEL_ENABLE_GUC:-}
 INTEL_SKIP_INITRAMFS=${INTEL_SKIP_INITRAMFS:-0}
 INTEL_VERBOSE=${INTEL_VERBOSE:-1}
 
-vlog() { [ "$INTEL_VERBOSE" = 1 ] && echo "[intel] $*" || true; }
+vlog() { if [ "$INTEL_VERBOSE" = 1 ]; then echo "[intel] $*"; fi; }
 info() { echo "[intel] $*"; }
 warn() { echo "[intel][warn] $*" >&2; }
 

hosts/guard/pacman-hooks/pacman-pre-unlock-hosts.sh

@@ -45,8 +45,12 @@ cleanup_mount_stacks() {
 # Drop protective attributes if present
 if command -v lsattr >/dev/null 2>&1; then
 	attrs=$(lsattr -d "$TARGET" 2>/dev/null || true)
-  echo "$attrs" | grep -q " i " && chattr -i "$TARGET" > /dev/null 2>&1 || true
+	if echo "$attrs" | grep -q " i "; then
-  echo "$attrs" | grep -q " a " && chattr -a "$TARGET" > /dev/null 2>&1 || true
+		chattr -i "$TARGET" >/dev/null 2>&1 || true
+	fi
+	if echo "$attrs" | grep -q " a "; then
+		chattr -a "$TARGET" >/dev/null 2>&1 || true
+	fi
 fi
 
 stop_units_if_present

scripts/digital_wellbeing/pacman/pacman_wrapper.sh

@@ -536,8 +536,30 @@ function prompt_for_steam_challenge() {
 	fi
 }
 
+function check_for_virtualbox() {
+	# List of VirtualBox-related packages
+	local vbox_packages=("virtualbox" "virtualbox-host-modules-arch" "virtualbox-guest-iso" "virtualbox-ext-oracle")
+
+	# Check if the command is an installation command
+	if [[ $1 == "-S" || $1 == "-Sy" || $1 == "-Syu" || $1 == "-Syyu" || $1 == "-U" ]]; then
+		# Check all arguments
+		for arg in "$@"; do
+			# Strip repository prefix if present
+			local package_name="${arg##*/}"
+
+			# Check if argument matches any VirtualBox package
+			for package in "${vbox_packages[@]}"; do
+				if [[ $arg == "$package" || $arg == *"/$package-"* || $arg == *"/$package/"* ||
+					$arg == *"/$package" || $package_name == "$package" ]]; then
+					return 0 # VirtualBox package found
+				fi
+			done
+		done
+	fi
+	return 1 # No VirtualBox package found
+}
+
 # Function to prompt for solving a word unscrambling challenge (for virtualbox - always active)
-# shellcheck disable=SC2329  # Invoked dynamically when matching VirtualBox packages
 function prompt_for_virtualbox_challenge() {
 	echo -e "${YELLOW}WARNING: You are trying to install VirtualBox.${NC}"
 	echo -e "${YELLOW}VirtualBox challenge will begin shortly...${NC}"
@@ -681,6 +703,13 @@ if check_for_steam "$@"; then
 	fi
 fi
 
+# Check for VirtualBox (challenge-eligible package)
+if check_for_virtualbox "$@"; then
+	if ! prompt_for_virtualbox_challenge; then
+		exit 1
+	fi
+fi
+
 # Display operation
 display_operation "$1"
 

scripts/features/install_unreal_mcp.sh

@@ -176,7 +176,7 @@ install_launcher() {
 	cat >"$launcher" <<EOF
 #!/bin/bash
 set -euo pipefail
-exec uv --directory "$python_dir" run unreal_mcp_server.py "${1:-}" < /dev/null
+exec uv --directory "$python_dir" run unreal_mcp_server.py "\${1:-}" < /dev/null
 EOF
 	chmod +x "$launcher"
 	if [[ $EUID -eq 0 ]]; then chown "$ACTUAL_USER:$ACTUAL_USER" "$launcher"; fi

scripts/misc/testsAndMisc-bash/libre_translate.sh

@@ -476,7 +476,9 @@ main() {
 	else
 		echo "API key authentication DISABLED (public instance)."
 	fi
-  [[ -n ${PRELOAD_LANGS} ]] && echo "Preloaded languages requested: ${PRELOAD_LANGS}" || true
+	if [[ -n ${PRELOAD_LANGS} ]]; then
+		echo "Preloaded languages requested: ${PRELOAD_LANGS}"
+	fi
 	echo "Environment file: ${ENV_FILE}"
 	echo "Manage: docker logs -f ${SERVICE_NAME} | docker stop ${SERVICE_NAME}"
 	echo "Uninstall: sudo ${SCRIPT_NAME} --uninstall"

scripts/misc/testsAndMisc-bash/transcribe.sh

@@ -66,7 +66,9 @@ has_libcublas12() {
 		/usr/local/cuda-12*/lib64 \
 		/opt/cuda/lib64 \
 		/opt/cuda/targets/x86_64-linux/lib; do
-    [[ -e "$d/libcublas.so.12" ]] && return 0 || true
+		if [[ -e "$d/libcublas.so.12" ]]; then
+			return 0
+		fi
 	done
 	# venv-provided NVIDIA CUDA libs
 	if [[ -x "$VENV_DIR/bin/python" ]]; then
@@ -76,7 +78,9 @@ has_libcublas12() {
 			for d in "$VENV_DIR/lib/python$pyver/site-packages/nvidia/cublas/lib" \
 				"$VENV_DIR/lib/python$pyver/site-packages/nvidia/cudnn/lib" \
 				"$VENV_DIR/lib/python$pyver/site-packages/nvidia/cuda_runtime/lib"; do
-        [[ -e "$d/libcublas.so.12" ]] && return 0 || true
+				if [[ -e "$d/libcublas.so.12" ]]; then
+					return 0
+				fi
 			done
 		fi
 	fi