mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-07-04 15:03:15 +02:00
- Refactor RunnerUp verification: extract RunnerUpDbMixin (_runnerup_db.py), split _scan_and_fill_week_runnerup into a helper _try_fill_runnerup_for_date to keep cyclomatic complexity ≤10 - Generalise TCX lookup to any date in the ISO week (was today-only); all gap days Mon→today auto-filled on every startup and 08:30 timer firing - Add _adjust_shutdown_time_by(): +1h per extra workout beyond the 4-workout minimum, capped at midnight (hour=24) - Add _shutdown_base.py: daily reset of shutdown config to a stored base so the bonus doesn't silently accumulate across days - Add _extra_benefits.py: streak tracking, skip credits (earn (n-4) credits for 5+ workout weeks), early-bird extension to 09:00 for eligible weeks - Add --status mode (_status.py): non-locking CLI view showing per-day breakdown (✓/✗), RunnerUp auto-scan, bonus status, shutdown time, streak, skip credits, and early-bird status - Hook carrot into _check_non_verify_exits: bonus applied whenever auto-fill pushes weekly count above the minimum - Pass all pre-commit hooks (ruff, mypy, pylint, bandit, shellcheck, codespell, max-file-length); 508 tests at 100% branch coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017auyHmf2ZwQcDAwXaSo7KX
147 lines
4.8 KiB
Python
147 lines
4.8 KiB
Python
"""Tests for UI flows coverage gaps (part 2)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestUpdateSickCountdownAtZero:
|
|
"""Tests for _update_sick_countdown at zero remaining."""
|
|
|
|
def test_records_sick_day_and_unlocks_at_zero(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test countdown at zero records sick day and calls unlock."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.sick_remaining_time = 0
|
|
locker.sick_countdown_label = MagicMock()
|
|
locker.workout_data = {}
|
|
locker.log_file = tmp_path / "workout_log.json"
|
|
object.__setattr__(locker, "unlock_screen", MagicMock())
|
|
|
|
locker._update_sick_countdown()
|
|
|
|
assert locker.workout_data["type"] == "sick_day"
|
|
assert locker.workout_data["note"] == "Sick day - shutdown moved earlier"
|
|
locker.unlock_screen.assert_called_once()
|
|
|
|
|
|
class TestStartRunnerupFallback:
|
|
"""Tests for _start_runnerup_fallback (lines 114-121)."""
|
|
|
|
def test_submits_verify_and_stores_future(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Fallback sets up future and on_failure, then calls _poll_runnerup_fallback."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
on_failure = MagicMock()
|
|
|
|
mock_future = MagicMock()
|
|
mock_executor = MagicMock()
|
|
mock_executor.submit.return_value = mock_future
|
|
|
|
object.__setattr__(
|
|
locker,
|
|
"_verify_runnerup_workout",
|
|
MagicMock(return_value=("not_verified", "no")),
|
|
)
|
|
|
|
with (
|
|
patch(
|
|
"screen_locker._ui_flows.ThreadPoolExecutor",
|
|
return_value=mock_executor,
|
|
),
|
|
patch.object(locker, "_poll_runnerup_fallback"),
|
|
):
|
|
locker._start_runnerup_fallback(on_failure)
|
|
|
|
assert locker._runnerup_future is mock_future
|
|
assert locker._runnerup_on_failure is on_failure
|
|
|
|
|
|
class TestPollRunnerupFallback:
|
|
"""Tests for _poll_runnerup_fallback (lines 125-139)."""
|
|
|
|
def test_routes_to_unlock_when_verified(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Future done + verified → sets workout_data and schedules unlock (lines 127-135)."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_future = MagicMock()
|
|
mock_future.done.return_value = True
|
|
mock_future.result.return_value = ("verified", "Running: 6.0 km in 40 min")
|
|
locker._runnerup_future = mock_future
|
|
locker._runnerup_on_failure = MagicMock()
|
|
locker.workout_data = {}
|
|
object.__setattr__(locker, "unlock_screen", MagicMock())
|
|
|
|
locker._poll_runnerup_fallback()
|
|
|
|
assert locker.workout_data["type"] == "runnerup_verified"
|
|
assert locker.workout_data["source"] == "Running: 6.0 km in 40 min"
|
|
locker.root.after.assert_called()
|
|
|
|
def test_calls_on_failure_when_not_verified(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Future done + non-verified → on_failure callback invoked (lines 136-137)."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_future = MagicMock()
|
|
mock_future.done.return_value = True
|
|
mock_future.result.return_value = ("no_phone", "no phone connected")
|
|
on_failure = MagicMock()
|
|
locker._runnerup_future = mock_future
|
|
locker._runnerup_on_failure = on_failure
|
|
|
|
locker._poll_runnerup_fallback()
|
|
|
|
on_failure.assert_called_once()
|
|
|
|
def test_schedules_retry_when_future_not_done(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Future still running → schedule next poll after 500 ms (lines 138-139)."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_future = MagicMock()
|
|
mock_future.done.return_value = False
|
|
locker._runnerup_future = mock_future
|
|
|
|
locker._poll_runnerup_fallback()
|
|
|
|
locker.root.after.assert_called_with(500, locker._poll_runnerup_fallback)
|
|
|
|
def test_schedules_retry_when_future_is_none(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""None future (not started yet) → poll again in 500 ms."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker._runnerup_future = None
|
|
|
|
locker._poll_runnerup_fallback()
|
|
|
|
locker.root.after.assert_called_with(500, locker._poll_runnerup_fallback)
|