mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-07-04 15:03:15 +02:00
Krzysztof kuhy Rudnicki
d56ed74acc
Fix ruff violations in ~15 source files and ~60+ test files to minimize per-file-ignores in pyproject.toml. Remaining ignores are justified with comments explaining why each suppression is necessary. Source fixes: FBT003 (keyword args), S310 (URL validation), SLF001 (private access), T201 (print→logging), C901 (complexity), E501 (line length), E402 (import order). Test fixes: SIM117 (combined with), FBT (boolean args), PERF203 (try in loop), S310/S607 (URLs/executables), E402/E501 (imports/lines), S108 (tmp paths), PLR0913 (too many args), ARG (unused args), ANN (type annotations), RUF059 (unused unpacked vars), PT019 (fixture naming). Remaining per-file-ignores (with justifications): - Tests: ARG, D, PLC0415, PLR2004, S101, SLF001 - music_gen sources: PLC0415 (heavy ML lazy imports) - moviepy_showcase: PLC0415 (circular dependency) - generate_images: PLR0913 (matplotlib helpers need many params) - praca_magisterska_video: E501, E402 (long paths, mpl.use)
317 lines
10 KiB
Python
317 lines
10 KiB
Python
"""Tests for shutdown schedule adjustment coverage gaps (part 3)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import subprocess
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from python_pkg.screen_locker._constants import ADJUST_SHUTDOWN_SCRIPT
|
|
from python_pkg.screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestRestoreOriginalConfigIfNeeded:
|
|
"""Tests for _restore_original_config_if_needed method."""
|
|
|
|
def test_no_state_file_does_nothing(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test does nothing when no state file exists."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_file = MagicMock()
|
|
mock_file.exists.return_value = False
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.SICK_DAY_STATE_FILE",
|
|
mock_file,
|
|
):
|
|
locker._restore_original_config_if_needed()
|
|
|
|
def test_restores_when_state_from_previous_day(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test restores config when state date differs from today."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text(
|
|
json.dumps(
|
|
{
|
|
"date": "2020-01-01",
|
|
"original_mon_wed_hour": 21,
|
|
"original_thu_sun_hour": 20,
|
|
}
|
|
)
|
|
)
|
|
with (
|
|
patch(
|
|
"python_pkg.screen_locker._shutdown.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
),
|
|
patch.object(locker, "_write_restored_config") as mock_restore,
|
|
):
|
|
locker._restore_original_config_if_needed()
|
|
mock_restore.assert_called_once_with(21, 20, "2020-01-01")
|
|
|
|
def test_does_not_restore_when_state_from_today(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test does not restore when state date matches today."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
from datetime import datetime, timezone
|
|
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text(
|
|
json.dumps(
|
|
{
|
|
"date": today,
|
|
"original_mon_wed_hour": 21,
|
|
"original_thu_sun_hour": 20,
|
|
}
|
|
)
|
|
)
|
|
with (
|
|
patch(
|
|
"python_pkg.screen_locker._shutdown.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
),
|
|
patch.object(locker, "_write_restored_config") as mock_restore,
|
|
):
|
|
locker._restore_original_config_if_needed()
|
|
mock_restore.assert_not_called()
|
|
|
|
def test_returns_when_loaded_state_is_none(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns early when loaded state is None."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text(json.dumps({"date": "2020-01-01"}))
|
|
with (
|
|
patch(
|
|
"python_pkg.screen_locker._shutdown.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
),
|
|
patch.object(locker, "_write_restored_config") as mock_restore,
|
|
):
|
|
locker._restore_original_config_if_needed()
|
|
mock_restore.assert_not_called()
|
|
|
|
def test_handles_oserror(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test handles OSError when loading state."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_file = MagicMock()
|
|
mock_file.exists.return_value = True
|
|
mock_file.open.side_effect = OSError("fail")
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.SICK_DAY_STATE_FILE",
|
|
mock_file,
|
|
):
|
|
locker._restore_original_config_if_needed()
|
|
|
|
def test_handles_json_decode_error(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test handles JSONDecodeError when loading state."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
state_file = tmp_path / "state.json"
|
|
state_file.write_text("not valid json{{{")
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.SICK_DAY_STATE_FILE",
|
|
state_file,
|
|
):
|
|
locker._restore_original_config_if_needed()
|
|
|
|
|
|
class TestReadShutdownConfig:
|
|
"""Tests for _read_shutdown_config method."""
|
|
|
|
def test_returns_none_when_file_missing(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns None when config file doesn't exist."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_file = MagicMock()
|
|
mock_file.exists.return_value = False
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.SHUTDOWN_CONFIG_FILE",
|
|
mock_file,
|
|
):
|
|
assert locker._read_shutdown_config() is None
|
|
|
|
def test_reads_valid_config(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test reads all three config values from file."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
config_file = tmp_path / "shutdown.conf"
|
|
config_file.write_text("MON_WED_HOUR=21\nTHU_SUN_HOUR=20\nMORNING_END_HOUR=8\n")
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.SHUTDOWN_CONFIG_FILE",
|
|
config_file,
|
|
):
|
|
result = locker._read_shutdown_config()
|
|
assert result == (21, 20, 8)
|
|
|
|
def test_returns_none_when_values_missing(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns None when config has missing keys."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
config_file = tmp_path / "shutdown.conf"
|
|
config_file.write_text("MON_WED_HOUR=21\n")
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.SHUTDOWN_CONFIG_FILE",
|
|
config_file,
|
|
):
|
|
result = locker._read_shutdown_config()
|
|
assert result is None
|
|
|
|
|
|
class TestBuildShutdownCmd:
|
|
"""Tests for _build_shutdown_cmd method."""
|
|
|
|
def test_without_restore(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test command without restore flag."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
cmd = locker._build_shutdown_cmd(21, 20, 8, restore=False)
|
|
assert cmd == [
|
|
"/usr/bin/sudo",
|
|
str(ADJUST_SHUTDOWN_SCRIPT),
|
|
"21",
|
|
"20",
|
|
"8",
|
|
]
|
|
|
|
def test_with_restore(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test command with restore flag."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
cmd = locker._build_shutdown_cmd(21, 20, 8, restore=True)
|
|
assert cmd == [
|
|
"/usr/bin/sudo",
|
|
str(ADJUST_SHUTDOWN_SCRIPT),
|
|
"--restore",
|
|
"21",
|
|
"20",
|
|
"8",
|
|
]
|
|
|
|
|
|
class TestWriteShutdownConfig:
|
|
"""Tests for _write_shutdown_config method."""
|
|
|
|
def test_returns_false_when_script_missing(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns False when adjust script doesn't exist."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_script = MagicMock()
|
|
mock_script.exists.return_value = False
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.ADJUST_SHUTDOWN_SCRIPT",
|
|
mock_script,
|
|
):
|
|
result = locker._write_shutdown_config(21, 20, 8)
|
|
assert result is False
|
|
|
|
def test_success_calls_run_shutdown_cmd(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test successful config write delegates to _run_shutdown_cmd."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_script = MagicMock()
|
|
mock_script.exists.return_value = True
|
|
with (
|
|
patch(
|
|
"python_pkg.screen_locker._shutdown.ADJUST_SHUTDOWN_SCRIPT",
|
|
mock_script,
|
|
),
|
|
patch.object(locker, "_run_shutdown_cmd", return_value=True) as mock_run,
|
|
):
|
|
result = locker._write_shutdown_config(21, 20, 8)
|
|
assert result is True
|
|
mock_run.assert_called_once()
|
|
|
|
|
|
class TestRunShutdownCmd:
|
|
"""Tests for _run_shutdown_cmd method."""
|
|
|
|
def test_success(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test successful command execution."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
mock_result = MagicMock(stdout="OK\n")
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.subprocess.run",
|
|
return_value=mock_result,
|
|
):
|
|
result = locker._run_shutdown_cmd(["cmd"], 21, 20)
|
|
assert result is True
|
|
|
|
def test_returns_false_on_subprocess_error(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test returns False on SubprocessError."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch(
|
|
"python_pkg.screen_locker._shutdown.subprocess.run",
|
|
side_effect=subprocess.CalledProcessError(1, "cmd"),
|
|
):
|
|
result = locker._run_shutdown_cmd(["cmd"], 21, 20)
|
|
assert result is False
|