mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-07-04 15:03:15 +02:00
Krzysztof kuhy Rudnicki
e25d806742
The screen locker skipped enforcement on 2026-07-03 without ever showing a lock: a banked skip credit (earned from a prior 5+/week streak) was consumed automatically with no confirmation and no visible log. Reworked the whole reward mechanic instead of just gating it, since banking a "skip a future workout" credit works against maximizing weekly workouts: - Removed skip credits entirely (has_skip_credit/consume_skip_credit and the confirmation dialog built to gate them). The only same-day skip paths left are heat_skip and sick_day, both requiring a genuine reason. - Extra workouts (5+/week) now bank shutdown-time-later hours for the following week instead — comfort, not reduced enforcement. Reuses the existing _adjust_shutdown_time_by and reset_to_base_if_new_day's previously-discarded return value as the once-per-day gate. - early_bird and sick_day no longer pollute workout_log.json. early_bird is a same-day pending marker now stored in its own self-expiring, HMAC-signed file; sick_day is sourced entirely from sick_history.json (already the real source of truth). Fixes an accidental-safety gap where "already took a sick day today" only halted startup by luck. - Cleaned up 3 stale non-workout entries already in workout_log.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QdTccgbK7624kfoaV6CtXS
202 lines
7.3 KiB
Python
202 lines
7.3 KiB
Python
"""Tests for _check_today_state_exits and scheduled-skip branches."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker.tests.conftest import create_locker, create_locker_relaxed_day
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
from screen_locker.screen_lock import ScreenLocker
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _check_today_state_exits: return True/False branches
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestCheckTodayStateExits:
|
|
"""Cover all return True/False paths in _check_today_state_exits.
|
|
|
|
sys.exit is mocked without side_effect so execution continues past it
|
|
and the 'return True' statements are reachable.
|
|
"""
|
|
|
|
def _make_locker(self, mock_tk: MagicMock, tmp_path: Path) -> ScreenLocker:
|
|
return create_locker(mock_tk, tmp_path)
|
|
|
|
def test_early_bird_upgrade_success_returns_true(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=True),
|
|
patch.object(locker, "_is_early_bird_time", return_value=False),
|
|
patch.object(locker, "_try_auto_upgrade_early_bird", return_value=True),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is True
|
|
|
|
def test_early_bird_upgrade_fail_returns_false(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=True),
|
|
patch.object(locker, "_is_early_bird_time", return_value=False),
|
|
patch.object(locker, "_try_auto_upgrade_early_bird", return_value=False),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is False
|
|
|
|
def test_early_bird_window_active_returns_true(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=True),
|
|
patch.object(locker, "_is_early_bird_time", return_value=True),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is True
|
|
|
|
def test_sick_day_auto_upgrade_returns_true(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=False),
|
|
patch.object(locker, "_is_sick_day_today", return_value=True),
|
|
patch.object(locker, "_try_auto_upgrade_sick_day", return_value=True),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is True
|
|
|
|
def test_sick_day_no_upgrade_still_returns_true(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""A sick day already marked today halts startup even when no real
|
|
workout is found to upgrade it - sick_day no longer lives in
|
|
workout_log.json, so this halt must be explicit (see
|
|
_auto_upgrade.py's _check_today_state_exits), not an accidental
|
|
side effect of has_logged_today() catching a leftover log entry."""
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=False),
|
|
patch.object(locker, "_is_sick_day_today", return_value=True),
|
|
patch.object(locker, "_try_auto_upgrade_sick_day", return_value=False),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is True
|
|
|
|
def test_workout_skip_today_returns_true(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=False),
|
|
patch.object(locker, "_is_sick_day_today", return_value=False),
|
|
patch.object(locker, "has_logged_today", return_value=False),
|
|
patch(
|
|
"screen_locker._auto_upgrade.has_workout_skip_today",
|
|
return_value=True,
|
|
),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is True
|
|
|
|
def test_early_bird_time_returns_true(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=False),
|
|
patch.object(locker, "_is_sick_day_today", return_value=False),
|
|
patch.object(locker, "has_logged_today", return_value=False),
|
|
patch(
|
|
"screen_locker._auto_upgrade.has_workout_skip_today",
|
|
return_value=False,
|
|
),
|
|
patch.object(locker, "_is_early_bird_time", return_value=True),
|
|
patch.object(locker, "_save_early_bird_pending"),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is True
|
|
|
|
def test_no_exit_conditions_returns_false(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = self._make_locker(mock_tk, tmp_path)
|
|
with (
|
|
patch.object(locker, "_is_early_bird_pending", return_value=False),
|
|
patch.object(locker, "_is_sick_day_today", return_value=False),
|
|
patch.object(locker, "has_logged_today", return_value=False),
|
|
patch(
|
|
"screen_locker._auto_upgrade.has_workout_skip_today",
|
|
return_value=False,
|
|
),
|
|
patch.object(locker, "_is_early_bird_time", return_value=False),
|
|
):
|
|
result = locker._check_today_state_exits()
|
|
assert result is False
|
|
|
|
|
|
class TestCheckNonVerifyExitsScheduledSkip:
|
|
"""Cover the return after scheduled-skip sys.exit in _check_non_verify_exits."""
|
|
|
|
def test_scheduled_skip_return_reached(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
with patch.object(locker, "_is_scheduled_skip_today", return_value=True):
|
|
locker._check_non_verify_exits()
|
|
mock_sys_exit.assert_called_once_with(0)
|
|
|
|
|
|
class TestRelaxedDayCloseAndRun:
|
|
"""No LockWindow is built on a relaxed day; close()/run() use root."""
|
|
|
|
def test_relaxed_day_close_and_run_use_root_directly(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
locker = create_locker_relaxed_day(mock_tk, tmp_path)
|
|
assert locker._lock is None
|
|
|
|
locker.run()
|
|
locker.root.mainloop.assert_called_once()
|
|
|
|
locker.close()
|
|
locker.root.destroy.assert_called_once()
|