mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-07-04 13:03:11 +02:00
Krzysztof kuhy Rudnicki
74a8bd7529
- Refactor RunnerUp verification: extract RunnerUpDbMixin (_runnerup_db.py), split _scan_and_fill_week_runnerup into a helper _try_fill_runnerup_for_date to keep cyclomatic complexity ≤10 - Generalise TCX lookup to any date in the ISO week (was today-only); all gap days Mon→today auto-filled on every startup and 08:30 timer firing - Add _adjust_shutdown_time_by(): +1h per extra workout beyond the 4-workout minimum, capped at midnight (hour=24) - Add _shutdown_base.py: daily reset of shutdown config to a stored base so the bonus doesn't silently accumulate across days - Add _extra_benefits.py: streak tracking, skip credits (earn (n-4) credits for 5+ workout weeks), early-bird extension to 09:00 for eligible weeks - Add --status mode (_status.py): non-locking CLI view showing per-day breakdown (✓/✗), RunnerUp auto-scan, bonus status, shutdown time, streak, skip credits, and early-bird status - Hook carrot into _check_non_verify_exits: bonus applied whenever auto-fill pushes weekly count above the minimum - Pass all pre-commit hooks (ruff, mypy, pylint, bandit, shellcheck, codespell, max-file-length); 508 tests at 100% branch coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017auyHmf2ZwQcDAwXaSo7KX
355 lines
12 KiB
Python
355 lines
12 KiB
Python
"""Tests for RunnerUpVerificationMixin in _runnerup_verification.py."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
from typing import TYPE_CHECKING, Any
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
# Minimal valid TCX XML for a 40-minute, 6-km run.
|
|
_TCX_RUNNING = """\
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<TrainingCenterDatabase
|
|
xmlns="http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2">
|
|
<Activities>
|
|
<Activity Sport="Running">
|
|
<Lap>
|
|
<TotalTimeSeconds>2400.0</TotalTimeSeconds>
|
|
<DistanceMeters>6000.0</DistanceMeters>
|
|
</Lap>
|
|
</Activity>
|
|
</Activities>
|
|
</TrainingCenterDatabase>
|
|
"""
|
|
|
|
# TCX with an unrecognised sport tag (not in RUNNERUP_ACCEPTED_SPORTS).
|
|
_TCX_GYM = """\
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<TrainingCenterDatabase
|
|
xmlns="http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2">
|
|
<Activities>
|
|
<Activity Sport="Gym">
|
|
<Lap>
|
|
<TotalTimeSeconds>3600.0</TotalTimeSeconds>
|
|
<DistanceMeters>0.0</DistanceMeters>
|
|
</Lap>
|
|
</Activity>
|
|
</Activities>
|
|
</TrainingCenterDatabase>
|
|
"""
|
|
|
|
# Two laps that together make a valid run.
|
|
_TCX_MULTI_LAP = """\
|
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
<TrainingCenterDatabase
|
|
xmlns="http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2">
|
|
<Activities>
|
|
<Activity Sport="Running">
|
|
<Lap>
|
|
<TotalTimeSeconds>1200.0</TotalTimeSeconds>
|
|
<DistanceMeters>3000.0</DistanceMeters>
|
|
</Lap>
|
|
<Lap>
|
|
<TotalTimeSeconds>1200.0</TotalTimeSeconds>
|
|
<DistanceMeters>3000.0</DistanceMeters>
|
|
</Lap>
|
|
</Activity>
|
|
</Activities>
|
|
</TrainingCenterDatabase>
|
|
"""
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
def _write_tcx(tmp_path: Path, content: str, name: str = "activity.tcx") -> str:
|
|
"""Write TCX content to a temp file and return the path string."""
|
|
p = tmp_path / name
|
|
p.write_text(content)
|
|
return str(p)
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _validate_runnerup_data
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
class TestScanAndFillWeekRunnerup:
|
|
"""Tests for _scan_and_fill_week_runnerup (lines 186-248)."""
|
|
|
|
def test_returns_zero_when_no_phone(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""No ADB device → 0 filled."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("{}")
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=False))
|
|
assert locker._scan_and_fill_week_runnerup(log_file) == 0
|
|
|
|
def test_returns_zero_when_all_days_already_logged(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""All days this week already have counted workouts → 0 new fills."""
|
|
from datetime import date, timedelta
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
|
|
# Fill Mon-today with phone_verified entries.
|
|
today = date.today()
|
|
monday = today - timedelta(days=today.weekday())
|
|
logs: dict[str, Any] = {}
|
|
cur = monday
|
|
while cur <= today:
|
|
logs[cur.strftime("%Y-%m-%d")] = {
|
|
"workout_data": {"type": "phone_verified"}
|
|
}
|
|
cur += timedelta(days=1)
|
|
log_file.write_text(json.dumps(logs))
|
|
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker, "_find_runnerup_exports_for_date", MagicMock(return_value=[])
|
|
)
|
|
assert locker._scan_and_fill_week_runnerup(log_file) == 0
|
|
|
|
def test_fills_gap_for_unlogged_day(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Gap in log + exports found + validated → entry written, count > 0."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("{}")
|
|
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=["/sdcard/run.tcx"]),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_pull_and_parse_tcx",
|
|
MagicMock(
|
|
return_value={"sport": 0, "duration_seconds": 2400, "distance_m": 6000}
|
|
),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_validate_runnerup_data",
|
|
MagicMock(return_value=("verified", "Running: 6.0 km in 40 min")),
|
|
)
|
|
|
|
with patch(
|
|
"screen_locker._runnerup_verification.compute_entry_hmac",
|
|
return_value="sig",
|
|
):
|
|
result = locker._scan_and_fill_week_runnerup(log_file)
|
|
|
|
assert result > 0
|
|
logs = json.loads(log_file.read_text())
|
|
# At least one date should have been filled.
|
|
types = [
|
|
v.get("workout_data", {}).get("type")
|
|
for v in logs.values()
|
|
if isinstance(v, dict)
|
|
]
|
|
assert "runnerup_verified" in types
|
|
|
|
def test_skips_date_when_no_exports(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""No exports for a date → date skipped, count stays 0."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("{}")
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=[]),
|
|
)
|
|
assert locker._scan_and_fill_week_runnerup(log_file) == 0
|
|
|
|
def test_skips_unreadable_tcx(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""_pull_and_parse_tcx returns None → remote skipped, not filled."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("{}")
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=["/sdcard/run.tcx"]),
|
|
)
|
|
object.__setattr__(locker, "_pull_and_parse_tcx", MagicMock(return_value=None))
|
|
assert locker._scan_and_fill_week_runnerup(log_file) == 0
|
|
|
|
def test_skips_not_verified_export(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""_validate_runnerup_data returns not-verified → date not filled."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("{}")
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=["/sdcard/run.tcx"]),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_pull_and_parse_tcx",
|
|
MagicMock(
|
|
return_value={"sport": 0, "duration_seconds": 60, "distance_m": 6000}
|
|
),
|
|
)
|
|
assert locker._scan_and_fill_week_runnerup(log_file) == 0
|
|
|
|
def test_returns_zero_on_write_error(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""OSError writing log after fill → returns 0 (lines 241-246)."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
|
|
# Can't patch PosixPath.open (read-only slot), so wrap it in a
|
|
# tiny class that delegates reads but raises on writes.
|
|
real_log = tmp_path / "log.json"
|
|
real_log.write_text("{}")
|
|
|
|
class _FailWrite:
|
|
def open(self, mode: str = "r", **kw):
|
|
if mode == "w":
|
|
msg = "disk full"
|
|
raise OSError(msg)
|
|
return real_log.open(mode, **kw)
|
|
|
|
fail_log = _FailWrite()
|
|
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=["/sdcard/run.tcx"]),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_pull_and_parse_tcx",
|
|
MagicMock(
|
|
return_value={"sport": 0, "duration_seconds": 2400, "distance_m": 6000}
|
|
),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_validate_runnerup_data",
|
|
MagicMock(return_value=("verified", "ok")),
|
|
)
|
|
|
|
with patch(
|
|
"screen_locker._runnerup_verification.compute_entry_hmac",
|
|
return_value="sig",
|
|
):
|
|
result = locker._scan_and_fill_week_runnerup(fail_log)
|
|
|
|
assert result == 0
|
|
|
|
def test_handles_corrupt_log_file(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Corrupt log JSON → starts with empty dict, still works."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("not-json")
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=[]),
|
|
)
|
|
# Should not raise; returns 0 (no exports found).
|
|
assert locker._scan_and_fill_week_runnerup(log_file) == 0
|
|
|
|
def test_hmac_none_still_fills_entry(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""HMAC key absent (compute_entry_hmac returns None) → entry still written."""
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
log_file = tmp_path / "log.json"
|
|
log_file.write_text("{}")
|
|
object.__setattr__(locker, "_has_adb_device", MagicMock(return_value=True))
|
|
object.__setattr__(
|
|
locker,
|
|
"_find_runnerup_exports_for_date",
|
|
MagicMock(return_value=["/sdcard/run.tcx"]),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_pull_and_parse_tcx",
|
|
MagicMock(
|
|
return_value={"sport": 0, "duration_seconds": 2400, "distance_m": 6000}
|
|
),
|
|
)
|
|
object.__setattr__(
|
|
locker,
|
|
"_validate_runnerup_data",
|
|
MagicMock(return_value=("verified", "Running: 6.0 km in 40 min")),
|
|
)
|
|
|
|
with patch(
|
|
"screen_locker._runnerup_verification.compute_entry_hmac",
|
|
return_value=None,
|
|
):
|
|
result = locker._scan_and_fill_week_runnerup(log_file)
|
|
|
|
assert result > 0
|
|
# No "hmac" key when signature is None.
|
|
logs = json.loads(log_file.read_text())
|
|
for entry in logs.values():
|
|
assert "hmac" not in entry
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# _find_runnerup_package
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|