mirror of
https://github.com/kuhyx/screen-locker.git
synced 2026-07-04 14:43:14 +02:00
Krzysztof kuhy Rudnicki
74a8bd7529
- Refactor RunnerUp verification: extract RunnerUpDbMixin (_runnerup_db.py), split _scan_and_fill_week_runnerup into a helper _try_fill_runnerup_for_date to keep cyclomatic complexity ≤10 - Generalise TCX lookup to any date in the ISO week (was today-only); all gap days Mon→today auto-filled on every startup and 08:30 timer firing - Add _adjust_shutdown_time_by(): +1h per extra workout beyond the 4-workout minimum, capped at midnight (hour=24) - Add _shutdown_base.py: daily reset of shutdown config to a stored base so the bonus doesn't silently accumulate across days - Add _extra_benefits.py: streak tracking, skip credits (earn (n-4) credits for 5+ workout weeks), early-bird extension to 09:00 for eligible weeks - Add --status mode (_status.py): non-locking CLI view showing per-day breakdown (✓/✗), RunnerUp auto-scan, bonus status, shutdown time, streak, skip credits, and early-bird status - Hook carrot into _check_non_verify_exits: bonus applied whenever auto-fill pushes weekly count above the minimum - Pass all pre-commit hooks (ruff, mypy, pylint, bandit, shellcheck, codespell, max-file-length); 508 tests at 100% branch coverage Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017auyHmf2ZwQcDAwXaSo7KX
343 lines
11 KiB
Python
343 lines
11 KiB
Python
"""Tests for screen_locker initialization, logging, and basic operations."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from datetime import datetime, timezone
|
|
import json
|
|
import tkinter as tk
|
|
from typing import TYPE_CHECKING, Any
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from screen_locker.screen_lock import _assert_not_under_pytest
|
|
from screen_locker.tests.conftest import create_locker
|
|
|
|
if TYPE_CHECKING:
|
|
from pathlib import Path
|
|
|
|
|
|
class TestAssertNotUnderPytest:
|
|
"""Tests for the _assert_not_under_pytest runtime guard."""
|
|
|
|
def test_raises_when_tk_is_real(self) -> None:
|
|
"""Guard fires if tk.Tk is the real tkinter class under pytest."""
|
|
with (
|
|
patch("screen_locker.screen_lock.tk", tk),
|
|
pytest.raises(RuntimeError, match="SAFETY"),
|
|
):
|
|
_assert_not_under_pytest()
|
|
|
|
def test_silent_when_tk_is_mocked(self) -> None:
|
|
"""Guard stays silent when tk is already mocked (normal test run)."""
|
|
_assert_not_under_pytest()
|
|
|
|
|
|
class TestScreenLockerInit:
|
|
"""Tests for ScreenLocker initialization."""
|
|
|
|
def test_init_demo_mode(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test initialization in demo mode."""
|
|
locker = create_locker(mock_tk, tmp_path, demo_mode=True)
|
|
|
|
assert locker.demo_mode is True
|
|
assert locker.lockout_time == 10
|
|
mock_sys_exit.assert_not_called()
|
|
|
|
def test_init_production_mode(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test initialization in production mode."""
|
|
locker = create_locker(mock_tk, tmp_path, demo_mode=False)
|
|
|
|
assert locker.demo_mode is False
|
|
assert locker.lockout_time == 1800
|
|
mock_sys_exit.assert_not_called()
|
|
|
|
def test_init_exits_if_logged_today(
|
|
self, mock_tk: MagicMock, mock_sys_exit: MagicMock, tmp_path: Path
|
|
) -> None:
|
|
"""Test that init exits early if workout logged today."""
|
|
mock_sys_exit.side_effect = SystemExit(0)
|
|
|
|
with pytest.raises(SystemExit):
|
|
create_locker(mock_tk, tmp_path, has_logged=True)
|
|
|
|
mock_sys_exit.assert_called_once_with(0)
|
|
|
|
|
|
class TestHasLoggedToday:
|
|
"""Tests for has_logged_today method."""
|
|
|
|
def test_no_log_file(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test when log file doesn't exist."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
|
|
locker.log_file = log_file
|
|
assert locker.has_logged_today() is False
|
|
|
|
def test_empty_log_file(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test when log file is empty/invalid JSON."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
log_file.write_text("")
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
assert locker.has_logged_today() is False
|
|
|
|
def test_invalid_json(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test when log file contains invalid JSON."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
log_file.write_text("{invalid json}")
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
assert locker.has_logged_today() is False
|
|
|
|
def test_today_logged(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test when today's workout is logged with valid HMAC."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
log_file.write_text(
|
|
json.dumps({today: {"workout": "data", "hmac": "valid"}}),
|
|
)
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
with patch(
|
|
"screen_locker._log_mixin.verify_entry_hmac",
|
|
return_value=True,
|
|
):
|
|
assert locker.has_logged_today() is True
|
|
|
|
def test_today_logged_invalid_hmac(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test rejects entry when HMAC verification fails."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
log_file.write_text(
|
|
json.dumps({today: {"workout": "data", "hmac": "tampered"}}),
|
|
)
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
with patch(
|
|
"screen_locker._log_mixin.verify_entry_hmac",
|
|
return_value=False,
|
|
):
|
|
assert locker.has_logged_today() is False
|
|
|
|
def test_today_unsigned_entry_no_hmac_key(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Accept unsigned entry when HMAC key is unavailable."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
log_file.write_text(
|
|
json.dumps({today: {"workout": "data"}}),
|
|
)
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
with (
|
|
patch(
|
|
"screen_locker._log_mixin.verify_entry_hmac",
|
|
return_value=False,
|
|
),
|
|
patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value=None,
|
|
),
|
|
):
|
|
assert locker.has_logged_today() is True
|
|
|
|
def test_today_unsigned_entry_with_hmac_key(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Reject unsigned entry when HMAC key IS available."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
log_file.write_text(
|
|
json.dumps({today: {"workout": "data"}}),
|
|
)
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
with (
|
|
patch(
|
|
"screen_locker._log_mixin.verify_entry_hmac",
|
|
return_value=False,
|
|
),
|
|
patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value="some-signature",
|
|
),
|
|
):
|
|
assert locker.has_logged_today() is False
|
|
|
|
def test_other_day_logged(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test when only other days are logged."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
log_file.write_text(json.dumps({"2020-01-01": {"workout": "data"}}))
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
assert locker.has_logged_today() is False
|
|
|
|
|
|
class TestSaveWorkoutLog:
|
|
"""Tests for save_workout_log method."""
|
|
|
|
def test_save_to_new_file(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test saving to a new log file includes HMAC."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
locker.workout_data = {"type": "running"}
|
|
with patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value="abc123",
|
|
):
|
|
locker.save_workout_log()
|
|
|
|
assert log_file.exists()
|
|
with log_file.open() as f:
|
|
data: dict[str, Any] = json.load(f)
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
assert today in data
|
|
assert data[today]["workout_data"]["type"] == "running"
|
|
assert data[today]["hmac"] == "abc123"
|
|
|
|
def test_save_to_new_file_no_hmac_key(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test saving without HMAC key produces unsigned entry."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
locker.workout_data = {"type": "running"}
|
|
with patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value=None,
|
|
):
|
|
locker.save_workout_log()
|
|
|
|
with log_file.open() as f:
|
|
data: dict[str, Any] = json.load(f)
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
assert "hmac" not in data[today]
|
|
|
|
def test_save_to_existing_file(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test saving appends to existing log file."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
log_file.write_text(json.dumps({"2020-01-01": {"old": "data"}}))
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
locker.workout_data = {"type": "strength"}
|
|
with patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value="sig",
|
|
):
|
|
locker.save_workout_log()
|
|
|
|
with log_file.open() as f:
|
|
data: dict[str, Any] = json.load(f)
|
|
assert "2020-01-01" in data
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
assert today in data
|
|
|
|
def test_save_with_corrupted_existing_file(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test saving when existing file is corrupted."""
|
|
log_file = tmp_path / "workout_log.json"
|
|
log_file.write_text("not valid json")
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
locker.workout_data = {"type": "running"}
|
|
with patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value="sig",
|
|
):
|
|
locker.save_workout_log()
|
|
|
|
with log_file.open() as f:
|
|
data: dict[str, Any] = json.load(f)
|
|
today = datetime.now(tz=timezone.utc).strftime("%Y-%m-%d")
|
|
assert today in data
|
|
|
|
def test_save_with_write_error(
|
|
self,
|
|
mock_tk: MagicMock,
|
|
mock_sys_exit: MagicMock,
|
|
tmp_path: Path,
|
|
) -> None:
|
|
"""Test saving handles write errors gracefully."""
|
|
log_file = tmp_path / "nonexistent_dir" / "workout_log.json"
|
|
|
|
locker = create_locker(mock_tk, tmp_path)
|
|
locker.log_file = log_file
|
|
locker.workout_data = {"type": "running"}
|
|
with patch(
|
|
"screen_locker._log_mixin.compute_entry_hmac",
|
|
return_value="sig",
|
|
):
|
|
# Should not raise, just log warning
|
|
locker.save_workout_log()
|